Moved "Parameter Properties" section above "this Types"#3492
Open
adriancuadrado wants to merge 1 commit intomicrosoft:v2from
Open
Moved "Parameter Properties" section above "this Types"#3492adriancuadrado wants to merge 1 commit intomicrosoft:v2from
adriancuadrado wants to merge 1 commit intomicrosoft:v2from
Conversation
In the `this-based type guards`](https://www.typescriptlang.org/docs/handbook/2/classes.html#this-based-type-guards) subsection of the [`this Types`](https://www.typescriptlang.org/docs/handbook/2/classes.html#this-types) section there is an example that uses a parameter property. This may confuse readers that are reading this article from top to bottom since you are using a feature that has not been explained yet.
Contributor
Author
|
This is the example code that uses parameter properties: class FileSystemObject {
isFile(): this is FileRep {
return this instanceof FileRep;
}
isDirectory(): this is Directory {
return this instanceof Directory;
}
isNetworked(): this is Networked & this {
return this.networked;
}
constructor(public path: string, private networked: boolean) {}
}This code is used in this-based type guards, but it is in the next section, where they are actually explained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
this-based type guardssubsection of thethis Typessection there is an example that uses a parameter property. This may confuse readers that are reading this article from top to bottom since you are using a feature that has not been explained yet.